Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding speakeasy drinks using existing AdventureResults #1431

Merged
merged 1 commit into from Jan 13, 2023

Conversation

Veracity0
Copy link
Contributor

@Veracity0 Veracity0 commented Jan 12, 2023

As reported by ... somebody.

When switching clans, speakeasy/hotdogs/floundry are rebuilt from saved clan lounge item lists.
Don't need to - can't - re-add the item to the item list.

@Veracity0 Veracity0 requested a review from a team as a code owner January 12, 2023 21:37
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #1431 (9c39f4d) into main (c9a5788) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1431   +/-   ##
=========================================
  Coverage     34.01%   34.01%           
- Complexity    16986    16988    +2     
=========================================
  Files          1053     1053           
  Lines        162560   162565    +5     
  Branches      34876    34877    +1     
=========================================
+ Hits          55296    55302    +6     
+ Misses        97866    97865    -1     
  Partials       9398     9398           
Impacted Files Coverage Δ
.../net/sourceforge/kolmafia/session/ClanManager.java 26.14% <0.00%> (+0.07%) ⬆️
...ourceforge/kolmafia/request/ClanLoungeRequest.java 33.30% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a5788...9c39f4d. Read the comment docs.

Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@midgleyc midgleyc merged commit a92674f into main Jan 13, 2023
@midgleyc midgleyc deleted the clan-lounge-fix branch January 13, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants