Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whetstone #1442

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Whetstone #1442

merged 2 commits into from
Jan 17, 2023

Conversation

Veracity0
Copy link
Contributor

  1. hard rock is multi usable
  2. When ConcoctionDatabase.getUsables was split into multiple lists, "food helpers" were added to the FOOD list.
    This includes items that are type USE - like Mayo - but forgot to include items that were USE_MULTIPLE - like munchies pills or whet stones. Now they are included again, and you can see and queue them in the Food panel of the Item Manager
  3. Speaking of which, the whet stone adds +1 adventure to the next food eaten.
    Handle it like we handle munchies pill

@Veracity0 Veracity0 requested a review from a team as a code owner January 17, 2023 14:43
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #1442 (94cc0a9) into main (fa0e420) will decrease coverage by 0.01%.
The diff coverage is 18.18%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1442      +/-   ##
============================================
- Coverage     34.10%   34.10%   -0.01%     
- Complexity    17004    17005       +1     
============================================
  Files          1053     1053              
  Lines        162674   162684      +10     
  Branches      34877    34879       +2     
============================================
- Hits          55484    55483       -1     
- Misses        97778    97786       +8     
- Partials       9412     9415       +3     
Impacted Files Coverage Δ
...forge/kolmafia/persistence/ConcoctionDatabase.java 53.30% <ø> (ø)
.../sourceforge/kolmafia/preferences/Preferences.java 86.42% <ø> (ø)
...t/sourceforge/kolmafia/request/EatItemRequest.java 21.00% <0.00%> (-0.23%) ⬇️
...t/sourceforge/kolmafia/request/UseItemRequest.java 14.37% <0.00%> (-0.02%) ⬇️
...lmafia/swingui/widget/ListCellRendererFactory.java 27.69% <0.00%> (-0.07%) ⬇️
...et/sourceforge/kolmafia/objectpool/Concoction.java 67.76% <100.00%> (+0.05%) ⬆️
...sourceforge/kolmafia/textui/langserver/Script.java 81.91% <0.00%> (-3.20%) ⬇️
...rceforge/kolmafia/persistence/HolidayDatabase.java 63.82% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa0e420...94cc0a9. Read the comment docs.

@Veracity0 Veracity0 merged commit da1510b into main Jan 17, 2023
@Veracity0 Veracity0 deleted the whetstone branch January 17, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants