Run ubuntu checks through xvfb

[Rinn]

This should allow headless ubuntu to run tests in swing components

[codecov]

Codecov Report

Merging #1454 (6c9c8cc) into main (bdff158) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1454      +/-   ##
============================================
- Coverage     34.22%   34.22%   -0.01%     
  Complexity    17123    17123              
============================================
  Files          1057     1057              
  Lines        163046   163046              
  Branches      34921    34921              
============================================
- Hits          55801    55798       -3     
- Misses        97825    97828       +3     
  Partials       9420     9420              

Impacted Files	Coverage Δ
src/net/sourceforge/kolmafia/RequestThread.java	36.96% <0.00%> (-1.22%)	⬇️
...eforge/kolmafia/swingui/panel/GearChangePanel.java	58.18% <0.00%> (-0.14%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdff158...6c9c8cc. Read the comment docs.

[jaadams5]

I merged this into #1441 and the failing test now runs and passes on Ubuntu.

[Veracity0]

So can we get this made a non-draft and therefore open for review?

[Veracity0]

My question is, what about non-Ubuntu platforms? Do we need to mark tests that depend on this as disabled for Mac and Windows? If so, how? And what can we do about it?

[jaadams5]

This was proposed as an environmental change to fix a failing test in #1441, It works. Locally Windows tests have passed with and without this. It would be reassuring to have someone confirm that this works locally on non-Windows systems.

For reference xvfb implements an X11 display server virtually. https://en.wikipedia.org/wiki/Xvfb

[jaadams5]

My question is, what about non-Ubuntu platforms? Do we need to mark tests that depend on this as disabled for Mac and Windows? If so, how? And what can we do about it?

This works on Windows. It is a change to the environment and I don't have any expectation that code or tests would have to be enabled or disabled because of this change. Before this GitHub ubuntu made no provisions for an X11 display in a test environment. Now code that uses an X11 display (i.e. creating some top level Swing components) can be run and tested.

[jaadams5]

I'm happy to approve and merge but I would like some confirmation that @Veracity0 's concerns have been addressed.

[midgleyc]

We can see that this works for Windows and Mac already because it was used to run a Swing test on #1441, where the Windows and Mac tests already passed.

[Veracity0]

Go for it.