Check coat of paint's modifiers after exiting avatar path #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1494 +/- ##
============================================
+ Coverage 34.73% 34.76% +0.03%
- Complexity 17378 17384 +6
============================================
Files 1062 1062
Lines 163275 163274 -1
Branches 34927 34926 -1
============================================
+ Hits 56712 56766 +54
+ Misses 97030 96975 -55
Partials 9533 9533
Continue to review full report at Codecov.
|
|
Oh dear, just realized that the test that should've been failing, was succeeding. |
midgleyc
reviewed
Feb 6, 2023
Comment on lines
1739
to
1741
| if (!KoLCharacter.hasEquipped(COAT_OF_PAINT, EquipmentManager.SHIRT) | ||
| && !KoLConstants.inventory.contains(COAT_OF_PAINT)) { | ||
| && COAT_OF_PAINT.getCount(KoLConstants.inventory) == 0 | ||
| && COAT_OF_PAINT.getCount(KoLConstants.closet) == 0) { |
There was a problem hiding this comment.
InventoryManager.getAccessibleCount instead (or one of the related methods)? Or do we really want exactly equipped, inventory + closet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce
With coat of paint in inventory or equipped, break the prism to exit an avatar path.
As the player's class has changed, coat of paint has its modifiers changed as well.
What happens
Mafia does not recognize coat of paint has changed and the equipment modifiers are now different.
The description was not visited as it should have been by mafia.
Manually checking the description will correct the modifiers.
What we expected instead
Mafia to check coat of paint and update the equipment modifiers without player intervention required.