Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The correct platform to step to in the volcano maze now has a white plus on it #1505

Merged
merged 3 commits into from Feb 7, 2023

Conversation

Veracity0
Copy link
Contributor

@Veracity0 Veracity0 commented Feb 7, 2023

I'm going to write s comment explaining exactly how KoL handles the maze:

  • Initial visit gives HTML with a "div" for each square specifying a "class" and an HTML link.
  • Each square is rendered via a "style" - classes "you", "goal", "yes", "no"
  • Javascript handles onClick for each square and submits a request.
  • KoL responds with JSON and the JS changes the "yes"/"no" status of each square as visibility changes and re-renders.

I will also get the raw HTML of visiting the maze - including line breaks - and will write a simple test for decorating that page.

And that is done. Hope it is helpful!

@Veracity0 Veracity0 requested a review from a team as a code owner February 7, 2023 06:10
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #1505 (f9d97a1) into main (8288e6a) will increase coverage by 0.00%.
The diff coverage is 80.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1505   +/-   ##
=========================================
  Coverage     34.76%   34.76%           
- Complexity    17382    17383    +1     
=========================================
  Files          1062     1062           
  Lines        163278   163283    +5     
  Branches      34926    34927    +1     
=========================================
+ Hits          56757    56768   +11     
+ Misses        96986    96980    -6     
  Partials       9535     9535           
Impacted Files Coverage Δ
src/net/sourceforge/kolmafia/KoLConstants.java 98.25% <ø> (ø)
...urceforge/kolmafia/session/VolcanoMazeManager.java 63.11% <80.00%> (+0.73%) ⬆️
...sourceforge/kolmafia/textui/langserver/Script.java 85.10% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8288e6a...f9d97a1. Read the comment docs.

Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will trust that you've tested this in-game :)

@Veracity0
Copy link
Contributor Author

Veracity0 commented Feb 7, 2023

Not only in-game, but in-run.

I love the Nemesis quest, so always have the volcanic island open by day two at the latest. I never claimed to be optimal. 😃

This time I got it open on day one and made the gif/wrote the code last night - and after rollover, spent less than 10 turns total on the island to reach the maze.

After getting my 5 Breathitin; I'm not COMPLETELY sub optimal.

The code worked fine first time, but I initially had actual animated gifs for the platformup{1234} images, and, try as I might, literally none of the online gif editing tools actually set the loop parameter to once only, even though they said they did. Instead, infinite looping - which is unacceptable.

But it looks great even if the "next" platform does not animate rising from the lava.

I am very happy with how this all worked out. I think it's all I want.

@Veracity0 Veracity0 merged commit 83d6ee6 into main Feb 7, 2023
@Veracity0 Veracity0 deleted the volcano-maze-images branch February 7, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants