Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: (un)equip command #1509

Merged
merged 3 commits into from Feb 8, 2023
Merged

tests: (un)equip command #1509

merged 3 commits into from Feb 8, 2023

Conversation

midgleyc
Copy link
Member

@midgleyc midgleyc commented Feb 7, 2023

Tests for unequipping and equipping things, especially folders, as this involves arithmetic with slots.

@midgleyc midgleyc requested a review from a team as a code owner February 7, 2023 20:49
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #1509 (7f95c9f) into main (4e47f94) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1509      +/-   ##
============================================
+ Coverage     34.81%   34.83%   +0.02%     
- Complexity    17433    17450      +17     
============================================
  Files          1063     1063              
  Lines        163296   163296              
  Branches      34928    34928              
============================================
+ Hits          56846    56887      +41     
+ Misses        96911    96866      -45     
- Partials       9539     9543       +4     
Impacted Files Coverage Δ
.../net/sourceforge/kolmafia/objectpool/ItemPool.java 14.28% <ø> (ø)
...sourceforge/kolmafia/session/EquipmentManager.java 40.06% <0.00%> (+0.08%) ⬆️
...eforge/kolmafia/persistence/EquipmentDatabase.java 74.01% <0.00%> (+0.21%) ⬆️
...lmafia/swingui/widget/ListCellRendererFactory.java 29.57% <0.00%> (+1.40%) ⬆️
...sourceforge/kolmafia/request/EquipmentRequest.java 31.33% <0.00%> (+2.09%) ⬆️
...eforge/kolmafia/textui/command/UnequipCommand.java 71.42% <0.00%> (+57.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e47f94...7f95c9f. Read the comment docs.

Copy link
Contributor

@gausie gausie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, and definitely get merged before the slot enum changes as I imagine was your intention!

@gausie gausie merged commit 007504c into kolmafia:main Feb 8, 2023
@midgleyc midgleyc deleted the equip-command-test branch February 8, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants