Buying hat from firework shop only requires autoSatisfyWithNPCs

[Veracity0]

A fireworks hat is an NPC-only quest item.
It should only require autoSatisfyWithNPC.
KoLmafia.makePurchases erroneously discarded the NPCPurchaseRequest since there was not an unlimited stock.

Fix: have it actually look for an NPCPurchaseRequest to decide it found one, rather than requiring an unlimited inventory to signal that.

[codecov]

Codecov Report

Merging #1528 (7b27aa3) into main (3d1455f) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1528      +/-   ##
============================================
+ Coverage     34.86%   34.88%   +0.02%     
- Complexity    17524    17546      +22     
============================================
  Files          1065     1065              
  Lines        163432   163434       +2     
  Branches      34936    34936              
============================================
+ Hits          56974    57011      +37     
+ Misses        96902    96861      -41     
- Partials       9556     9562       +6     

Impacted Files	Coverage Δ
src/net/sourceforge/kolmafia/KoLmafia.java	37.23% <0.00%> (+0.37%)	⬆️
.../sourceforge/kolmafia/session/ResultProcessor.java	28.30% <0.00%> (+0.13%)	⬆️
...urceforge/kolmafia/request/NPCPurchaseRequest.java	20.00% <0.00%> (+0.28%)	⬆️
...ceforge/kolmafia/persistence/NPCStoreDatabase.java	51.29% <0.00%> (+0.64%)	⬆️
...sourceforge/kolmafia/session/InventoryManager.java	36.08% <0.00%> (+1.86%)	⬆️
...ourceforge/kolmafia/request/MallSearchRequest.java	67.98% <0.00%> (+3.11%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d1455f...7b27aa3. Read the comment docs.

[midgleyc]

One question, but I think this is correct.

[midgleyc]

If autoSatisfyWithMall were true and autoSatisfyWithNPCs false, would purchasing work (I assume not)? Does willRetrieveIfCanUseMall use a different code path to willRetrieveIfCanUseNPCStore? Should it, given that you can't buy the fireworks hats in the mall?

[Veracity0]

It does not use a different code path.

    boolean shouldUseMall = !forceNoMall && InventoryManager.canUseMall(item);
...
      boolean onlyNPC = forceNoMall || !InventoryManager.canUseMall();
      List<PurchaseRequest> results =
          onlyNPC ? MallPriceManager.searchNPCs(item) : MallPriceManager.searchMall(instance);
...
  public static boolean canUseMall(final int itemId) {
    return ItemDatabase.isTradeable(itemId) && InventoryManager.canUseMall();
  }

Since the item is non-tradable, it always goes to the NPC store and the only PurchaseRequests are from the NPC store.