Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow Rift item drop penalty #1531

Merged
merged 8 commits into from
Feb 13, 2023
Merged

Shadow Rift item drop penalty #1531

merged 8 commits into from
Feb 13, 2023

Conversation

gausie
Copy link
Contributor

@gausie gausie commented Feb 13, 2023

Shadow Rift divides item drop bonuses by 5 for all fights that take place there, which needs support by mafia. We previously only dealt in "doublers" which I have renamed to "multipliers" to reflect this.

Also added some spaded item drops to the shadow monsters, and some missing elemental attacks to the shadow prism

@gausie gausie requested a review from a team as a code owner February 13, 2023 11:09
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #1531 (354717a) into main (77a167d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1531      +/-   ##
============================================
- Coverage     34.98%   34.97%   -0.02%     
+ Complexity    17587    17585       -2     
============================================
  Files          1067     1067              
  Lines        163590   163593       +3     
  Branches      34950    34951       +1     
============================================
- Hits          57231    57210      -21     
- Misses        96812    96839      +27     
+ Partials       9547     9544       -3     
Impacted Files Coverage Δ
src/net/sourceforge/kolmafia/Expression.java 91.19% <100.00%> (ø)
src/net/sourceforge/kolmafia/KoLCharacter.java 64.26% <100.00%> (-0.09%) ⬇️
src/net/sourceforge/kolmafia/Modifiers.java 71.01% <100.00%> (ø)
...net/sourceforge/kolmafia/textui/DataFileCache.java 37.73% <0.00%> (-5.67%) ⬇️
...sourceforge/kolmafia/textui/langserver/Script.java 80.85% <0.00%> (-4.26%) ⬇️
.../sourceforge/kolmafia/preferences/Preferences.java 84.84% <0.00%> (-1.59%) ⬇️
...forge/kolmafia/textui/langserver/FilesMonitor.java 79.48% <0.00%> (-1.29%) ⬇️
...lmafia/swingui/widget/ListCellRendererFactory.java 29.10% <0.00%> (-0.47%) ⬇️
...net/sourceforge/kolmafia/swingui/GenericFrame.java 23.91% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a167d...354717a. Read the comment docs.

@gausie gausie requested a review from midgleyc February 13, 2023 11:28
Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you have confirmed that this appears in modtrace as expected?

@gausie
Copy link
Contributor Author

gausie commented Feb 13, 2023

I assume you have confirmed that this appears in modtrace as expected?

I have! I even accidentally left some code to that effect in an earlier commit.

@gausie gausie enabled auto-merge (squash) February 13, 2023 11:31
@gausie gausie merged commit d8bbbe2 into main Feb 13, 2023
@gausie gausie deleted the shadow-rift-modifiers branch February 13, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants