-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadow Rift item drop penalty #1531
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
============================================
- Coverage 34.98% 34.97% -0.02%
+ Complexity 17587 17585 -2
============================================
Files 1067 1067
Lines 163590 163593 +3
Branches 34950 34951 +1
============================================
- Hits 57231 57210 -21
- Misses 96812 96839 +27
+ Partials 9547 9544 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you have confirmed that this appears in modtrace
as expected?
I have! I even accidentally left some code to that effect in an earlier commit. |
Shadow Rift divides item drop bonuses by 5 for all fights that take place there, which needs support by mafia. We previously only dealt in "doublers" which I have renamed to "multipliers" to reflect this.
Also added some spaded item drops to the shadow monsters, and some missing elemental attacks to the shadow prism