Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert familiar training goals to enum #1532

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

midgleyc
Copy link
Member

No description provided.

@midgleyc midgleyc added the enum-conversion Converting `public static final int`s to enums label Feb 13, 2023
@midgleyc midgleyc requested a review from a team as a code owner February 13, 2023 12:29
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #1532 (81ccb9e) into main (fb850c1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1532      +/-   ##
============================================
- Coverage     34.98%   34.98%   -0.01%     
  Complexity    17588    17588              
============================================
  Files          1067     1067              
  Lines        163601   163603       +2     
  Branches      34951    34947       -4     
============================================
- Hits          57233    57230       -3     
- Misses        96821    96825       +4     
- Partials       9547     9548       +1     
Impacted Files Coverage Δ
...eforge/kolmafia/swingui/FamiliarTrainingFrame.java 0.00% <0.00%> (ø)
.../kolmafia/textui/command/TrainFamiliarCommand.java 16.66% <0.00%> (ø)
...sourceforge/kolmafia/textui/langserver/Script.java 81.91% <0.00%> (-3.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb850c1...81ccb9e. Read the comment docs.

@gausie gausie merged commit d8c40bc into kolmafia:main Feb 13, 2023
@midgleyc midgleyc deleted the familiar-training-enum branch February 13, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enum-conversion Converting `public static final int`s to enums
Projects
None yet
2 participants