Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert wumpus deducations to enum (and make private) #1533

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

midgleyc
Copy link
Member

No description provided.

@midgleyc midgleyc added the enum-conversion Converting `public static final int`s to enums label Feb 13, 2023
@midgleyc midgleyc requested a review from a team as a code owner February 13, 2023 12:41
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #1533 (1886634) into main (d8bbbe2) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1533      +/-   ##
============================================
- Coverage     34.98%   34.96%   -0.02%     
+ Complexity    17588    17585       -3     
============================================
  Files          1067     1067              
  Lines        163593   163601       +8     
  Branches      34951    34951              
============================================
- Hits          57231    57209      -22     
- Misses        96814    96847      +33     
+ Partials       9548     9545       -3     
Impacted Files Coverage Δ
...et/sourceforge/kolmafia/session/WumpusManager.java 9.56% <0.00%> (-0.36%) ⬇️
...net/sourceforge/kolmafia/textui/DataFileCache.java 37.73% <0.00%> (-5.67%) ⬇️
...urceforge/kolmafia/swingui/menu/GlobalMenuBar.java 89.90% <0.00%> (-2.76%) ⬇️
.../sourceforge/kolmafia/preferences/Preferences.java 84.84% <0.00%> (-1.59%) ⬇️
.../sourceforge/kolmafia/swingui/menu/ScriptMenu.java 67.69% <0.00%> (-1.54%) ⬇️
...forge/kolmafia/textui/langserver/FilesMonitor.java 79.48% <0.00%> (-1.29%) ⬇️
...lmafia/swingui/widget/ListCellRendererFactory.java 29.10% <0.00%> (-0.47%) ⬇️
src/net/sourceforge/kolmafia/StaticEntity.java 21.78% <0.00%> (-0.28%) ⬇️
src/net/sourceforge/kolmafia/KoLCharacter.java 64.39% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8bbbe2...1886634. Read the comment docs.

@midgleyc midgleyc merged commit fb850c1 into kolmafia:main Feb 13, 2023
@midgleyc midgleyc deleted the wumpus-enum branch February 13, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enum-conversion Converting `public static final int`s to enums
Projects
None yet
2 participants