Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slot 'none' is number 0, not number -1 #1536

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

midgleyc
Copy link
Member

Off #1510, likely cause of autoscend issues.

Can confirm the issue (an issue) is fixed by running ash equipped_item($slot[none]) and not getting an error.

@midgleyc midgleyc requested a review from a team as a code owner February 13, 2023 16:27
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #1536 (85f0e81) into main (d8c40bc) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1536      +/-   ##
============================================
- Coverage     34.98%   34.97%   -0.02%     
+ Complexity    17588    17584       -4     
============================================
  Files          1067     1067              
  Lines        163603   163603              
  Branches      34947    34947              
============================================
- Hits          57234    57212      -22     
- Misses        96823    96848      +25     
+ Partials       9546     9543       -3     
Impacted Files Coverage Δ
src/net/sourceforge/kolmafia/textui/DataTypes.java 52.19% <100.00%> (ø)
...net/sourceforge/kolmafia/textui/DataFileCache.java 37.73% <0.00%> (-5.67%) ⬇️
.../sourceforge/kolmafia/request/StandardRequest.java 81.08% <0.00%> (-2.71%) ⬇️
.../sourceforge/kolmafia/preferences/Preferences.java 84.84% <0.00%> (-1.59%) ⬇️
...forge/kolmafia/textui/langserver/FilesMonitor.java 79.48% <0.00%> (-1.29%) ⬇️
...lmafia/swingui/widget/ListCellRendererFactory.java 29.10% <0.00%> (-0.47%) ⬇️
...net/sourceforge/kolmafia/swingui/GenericFrame.java 23.91% <0.00%> (-0.28%) ⬇️
src/net/sourceforge/kolmafia/KoLCharacter.java 64.26% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c40bc...85f0e81. Read the comment docs.

Copy link
Contributor

@jaadams5 jaadams5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your manual tests worked. I can run autoscend tomorrow.

@midgleyc midgleyc merged commit 6f4d1bb into kolmafia:main Feb 13, 2023
@midgleyc midgleyc deleted the slot-none-is-zero branch February 13, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants