Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find GitHub hosted repositories that are updated by SVN (Take 2) #1582

Merged
merged 4 commits into from Feb 26, 2023

Conversation

jaadams5
Copy link
Contributor

@jaadams5 jaadams5 commented Feb 25, 2023

A new command "checksvngit" that scans the local SVN directory for repositories that are hosted on GitHub. These repositories will not updated after January 2024.

Test code for this is deliberately not included because this could be removed from the codebase circa January 2024 as being no longer necessary, The complexity of mocking a repository seems like it is more effort than it is worth especially when "testing the test" might be appropriate. Checking out a repository from GitHub is feasible but if the test checks out the repository via SVN the test will fail in January 2024. If it is checked out via git then the test setup will still have to provide information that would be created by SVN.

See #1580 for some discussion that lead to this approach.

Sample Output
Local installation of coandco-mafia-NewYou-trunk uses SVN to update from GitHub.
Local installation of Ezandora-Choice-Override-branches-Release uses SVN to update from GitHub.
Local installation of Ezandora-Comb-Beach-trunk-Release uses SVN to update from GitHub.
Local installation of Ezandora-FantasyRealm-branches-Release uses SVN to update from GitHub.
Local installation of Ezandora-Gain-branches-Release uses SVN to update from GitHub.
Local installation of Ezandora-PirateRealm-trunk-Release uses SVN to update from GitHub.
Local installation of Ezandora-Voting-Booth-trunk-Release uses SVN to update from GitHub.
Local installation of gausie-excavator-trunk-RELEASE uses SVN to update from GitHub.
Local installation of matt-chugg-manuel_progress.git-trunk uses SVN to update from GitHub.
Local installation of phulin-shorts-ui-branches-master-build uses SVN to update from GitHub.
Local SVN repos scanned for possible GitHub access via SVN.

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Merging #1582 (26b6dca) into main (e863c92) will decrease coverage by 0.01%.
The diff coverage is 4.54%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1582      +/-   ##
============================================
- Coverage     35.14%   35.14%   -0.01%     
+ Complexity    17678    17677       -1     
============================================
  Files          1068     1068              
  Lines        163872   163894      +22     
  Branches      35013    35020       +7     
============================================
  Hits          57595    57595              
- Misses        96717    96739      +22     
  Partials       9560     9560              
Impacted Files Coverage Δ
...ourceforge/kolmafia/persistence/DebugDatabase.java 12.06% <0.00%> (-0.11%) ⬇️
...orge/kolmafia/textui/command/CheckDataCommand.java 4.54% <0.00%> (-0.15%) ⬇️
src/net/sourceforge/kolmafia/KoLmafiaCLI.java 70.18% <100.00%> (+0.04%) ⬆️
.../sourceforge/kolmafia/swingui/menu/ScriptMenu.java 67.69% <0.00%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e863c92...26b6dca. Read the comment docs.

Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@jaadams5 jaadams5 merged commit cfaa1dc into main Feb 26, 2023
@jaadams5 jaadams5 deleted the taketwo branch February 26, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants