Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include modifier in warning message #1603

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

midgleyc
Copy link
Member

@midgleyc midgleyc commented Mar 4, 2023

Apparently this message displays in TCRS, so add enough information to start to debug it.

@midgleyc midgleyc requested a review from a team as a code owner March 4, 2023 15:58
@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #1603 (e772cd4) into main (9ce85b3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1603   +/-   ##
=========================================
  Coverage     35.21%   35.21%           
  Complexity    17752    17752           
=========================================
  Files          1068     1068           
  Lines        163958   163958           
  Branches      35033    35033           
=========================================
+ Hits          57736    57741    +5     
+ Misses        96659    96655    -4     
+ Partials       9563     9562    -1     
Impacted Files Coverage Δ
...ceforge/kolmafia/persistence/ModifierDatabase.java 55.94% <100.00%> (ø)
src/net/sourceforge/kolmafia/RequestThread.java 38.18% <0.00%> (+1.21%) ⬆️
...sourceforge/kolmafia/textui/langserver/Script.java 85.10% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce85b3...e772cd4. Read the comment docs.

@midgleyc midgleyc merged commit 7a4d92c into kolmafia:main Mar 4, 2023
@midgleyc midgleyc deleted the modifier-on-warning branch March 4, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants