Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count shadow rift turn at end of fight, not start #1676

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

Veracity0
Copy link
Contributor

Per This report from Malibu Stacey:

encountersUntilSRChoice is being incremented at the start of combat. This means it will be off if you end combat in a manner which doesn't end combat (e.g Using the Force).

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #1676 (5fbaa8f) into main (cca7c84) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1676      +/-   ##
============================================
- Coverage     35.55%   35.55%   -0.01%     
- Complexity    17999    18002       +3     
============================================
  Files          1066     1066              
  Lines        164239   164240       +1     
  Branches      35109    35110       +1     
============================================
- Hits          58403    58402       -1     
- Misses        96147    96148       +1     
- Partials       9689     9690       +1     
Impacted Files Coverage Δ
...net/sourceforge/kolmafia/request/FightRequest.java 33.63% <100.00%> (+0.08%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca7c84...5fbaa8f. Read the comment docs.

@Veracity0 Veracity0 merged commit 081591e into main Apr 19, 2023
8 checks passed
@Veracity0 Veracity0 deleted the shadow-rift-fight branch April 19, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants