Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include chateau items in modifiers #1698

Merged
merged 2 commits into from May 12, 2023
Merged

Include chateau items in modifiers #1698

merged 2 commits into from May 12, 2023

Conversation

gausie
Copy link
Contributor

@gausie gausie commented May 12, 2023

Despite being in modifiers.txt, artificial skylight and antler chandelier mods were never actually applied. This fixes that

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #1698 (b244b2f) into main (bcd6980) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head b244b2f differs from pull request most recent head 1289321. Consider uploading reports for the commit 1289321 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1698   +/-   ##
=========================================
  Coverage     35.67%   35.68%           
- Complexity    18155    18156    +1     
=========================================
  Files          1066     1066           
  Lines        164360   164363    +3     
  Branches      35163    35164    +1     
=========================================
+ Hits          58636    58647   +11     
+ Misses        95989    95980    -9     
- Partials       9735     9736    +1     
Impacted Files Coverage Δ
src/net/sourceforge/kolmafia/KoLCharacter.java 64.42% <100.00%> (+0.04%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcd6980...1289321. Read the comment docs.

@gausie gausie marked this pull request as ready for review May 12, 2023 14:24
@gausie gausie requested a review from a team as a code owner May 12, 2023 14:24
Copy link
Contributor

@Veracity0 Veracity0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gausie gausie merged commit 38f660e into main May 12, 2023
6 checks passed
@gausie gausie deleted the artificial-skylight branch May 12, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants