Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set revision when building jar with gradle #17

Merged
merged 17 commits into from Sep 26, 2021
Merged

Set revision when building jar with gradle #17

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2ae80f5
Add revision to jar manifest and load in code
Rinn Sep 15, 2021
f4dc736
Override revision in tests
Rinn Sep 15, 2021
fb7f02b
Remove RELEASED
Rinn Sep 17, 2021
de3b925
Enable releases
Rinn Sep 18, 2021
c05abe9
move to StaticEntity, add build info
Rinn Sep 25, 2021
6656b77
Fix tests for revision numbers
gausie Sep 26, 2021
a7ead23
Change product name to CONSTANT_CASE
gausie Sep 26, 2021
50ae23d
Capitalize getBuildInfo properly
gausie Sep 26, 2021
0f833ca
We only have one MANIFEST file
gausie Sep 26, 2021
ab32bf1
Use r0 instead of rUnknown, make r0 pass all `since` checks
gausie Sep 26, 2021
d7ec072
Remove another manifest loop
gausie Sep 26, 2021
9392e66
Change Modified classifier back to M
gausie Sep 26, 2021
bb72ee7
Use system-agnostic File constructor on gradle
gausie Sep 26, 2021
6e3d2e2
Added shadow plugin
BadHorseMonkey Sep 26, 2021
32160e9
Fix version numbers - we have to use shadowJar
gausie Sep 26, 2021
0d5892a
Final tidy-up
gausie Sep 26, 2021
056bb64
Do not run the PR tests twice
gausie Sep 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Expand Up @@ -121,7 +121,7 @@ jar {
duplicatesStrategy = 'exclude'
destinationDirectory = file('dist/')
archiveBaseName = "KoLmafia"
classifier = "${versioning.info.dirty ? 'Modified' : ''}"
classifier = "${versioning.info.dirty ? 'M' : ''}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Note this is subtly different from what we have today with ant daily, namely we'll now have "KoLmafia-r12345-M.jar" instead of "KoLmafia-r12345M.jar". I don't think this is a meaningful difference.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah me and @BadHorseMonkey noticed this and thought that it might be alright given it allows you to split by - and grab [1]

}

task download(type: Copy) {
Expand Down