Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: undo special LoL standard familiar handling #1710

Merged
merged 1 commit into from May 18, 2023

Conversation

midgleyc
Copy link
Member

Now that standard.php no longer includes familiars, we don't need to special case this.

Probably worth waiting a little to confirm standard.php is stable before merging.

Now that standard.php no longer includes familiars, we don't need to
special case this.
@midgleyc midgleyc requested a review from a team as a code owner May 18, 2023 15:49
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #1710 (adc8d0d) into main (65b3cd8) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1710   +/-   ##
=========================================
  Coverage     35.76%   35.76%           
+ Complexity    18227    18225    -2     
=========================================
  Files          1068     1068           
  Lines        164549   164545    -4     
  Branches      35202    35200    -2     
=========================================
  Hits          58857    58857           
+ Misses        95944    95941    -3     
+ Partials       9748     9747    -1     
Impacted Files Coverage Δ
src/net/sourceforge/kolmafia/FamiliarData.java 60.50% <ø> (+0.17%) ⬆️
src/net/sourceforge/kolmafia/KoLCharacter.java 64.34% <ø> (-0.03%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b3cd8...adc8d0d. Read the comment docs.

Copy link
Contributor

@gausie gausie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have it on good authority that this is now stable!

@midgleyc midgleyc merged commit d098f18 into kolmafia:main May 18, 2023
5 checks passed
@midgleyc midgleyc deleted the lol-no-special-case-familiars branch May 18, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants