Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recommend the witchess buff in maximizer in lol #1729

Merged
merged 2 commits into from May 27, 2023

Conversation

midgleyc
Copy link
Member

In Legacy of Loathing, you can use the Witchess Set even though it's out of standard.

@midgleyc midgleyc requested a review from a team as a code owner May 27, 2023 15:04
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #1729 (16677ea) into main (4600882) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1729      +/-   ##
============================================
- Coverage     35.83%   35.82%   -0.01%     
  Complexity    18304    18304              
============================================
  Files          1069     1069              
  Lines        164777   164781       +4     
  Branches      35283    35287       +4     
============================================
- Hits          59046    59035      -11     
- Misses        95952    95966      +14     
- Partials       9779     9780       +1     
Impacted Files Coverage Δ
.../sourceforge/kolmafia/request/WitchessRequest.java 0.00% <0.00%> (ø)
...forge/kolmafia/textui/command/WitchessCommand.java 21.42% <0.00%> (-1.65%) ⬇️
.../net/sourceforge/kolmafia/maximizer/Maximizer.java 38.26% <50.00%> (+0.35%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4600882...16677ea. Read the comment docs.

@midgleyc midgleyc enabled auto-merge (squash) May 27, 2023 16:28
@midgleyc midgleyc merged commit 13316ab into kolmafia:main May 27, 2023
5 checks passed
@midgleyc midgleyc deleted the can-use-witchess-buff-lol branch May 27, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants