set ownsFloristFriar to true if it is owned

[Rinn]

This will allow scripts like av-snapshot or greenbox to report the florist friar as owned even if florist_available() returns false, such as a post community service run where the forest is inaccessible.

Also always set it as available if you can get into the choice instead of only on selecting choice 4

[codecov]

Codecov Report

Merging #1856 (509e904) into main (3877c6f) will increase coverage by 0.00%.
The diff coverage is 25.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #1856   +/-   ##
=========================================
  Coverage     36.31%   36.31%           
- Complexity    18746    18747    +1     
=========================================
  Files          1081     1081           
  Lines        166310   166312    +2     
  Branches      35385    35386    +1     
=========================================
+ Hits          60390    60402   +12     
+ Misses        96056    96042   -14     
- Partials       9864     9868    +4     

Files Changed	Coverage Δ
...t/sourceforge/kolmafia/request/FloristRequest.java	43.86% <25.00%> (+0.05%)	⬆️

... and 5 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3877c6f...509e904. Read the comment docs.

[s-k-z]

Why not trust the property when using the florist commands?

[Veracity0]

Legacy of Loathing offers a replica Order of the Green Thumb Order Form which grants in-run access to the Florist Friar.

[Rinn]

arg fricking lol

[Rinn]

Why not trust the property when using the florist commands?

you can't get to it if the forest is unavailable, or in standard

[s-k-z]

Why not trust the property when using the florist commands?

you can't get to it if the forest is unavailable, or in standard

Isn't that fine?

[Rinn]

Why not trust the property when using the florist commands?

you can't get to it if the forest is unavailable, or in standard

Isn't that fine?

I don't understand? This preference won't ever be set to false in code once it's set to true. It's to denote if you own the iotm, not if the friars is currently available.

[s-k-z]

Why not trust the property when using the florist commands?

you can't get to it if the forest is unavailable, or in standard

Isn't that fine?

I don't understand? This preference won't ever be set to false in code once it's set to true. It's to denote if you own the iotm, not if the friars is currently available.

Last I saw, florist_available() only returns true when you launch KoLmafia with it accessible. If this property is just cosmetic rather than functional, it won't behave like the others, where toggling it on would enable attempts to use the florist friars at runtime.

[Rinn]

Why not trust the property when using the florist commands?

you can't get to it if the forest is unavailable, or in standard

Isn't that fine?

I don't understand? This preference won't ever be set to false in code once it's set to true. It's to denote if you own the iotm, not if the friars is currently available.

Last I saw, florist_available() only returns true when you launch KoLmafia with it accessible. If this property is just cosmetic rather than functional, it won't behave like the others, where toggling it on would enable attempts to use the florist friars at runtime.

I intentionally didn't name this property to contain "Available", or "Always", or "Accessable" for this very reason.

[s-k-z]

Why not trust the property when using the florist commands?

you can't get to it if the forest is unavailable, or in standard

Isn't that fine?

I don't understand? This preference won't ever be set to false in code once it's set to true. It's to denote if you own the iotm, not if the friars is currently available.

Last I saw, florist_available() only returns true when you launch KoLmafia with it accessible. If this property is just cosmetic rather than functional, it won't behave like the others, where toggling it on would enable attempts to use the florist friars at runtime.

I intentionally didn't name this property to contain "Available", or "Always", or "Accessable" for this very reason.

Here is an example:

kolmafia/src/net/sourceforge/kolmafia/request/FancyDanRequest.java

Lines 94 to 100 in 3877c6f

	public static String accessible() {
	if (!Preferences.getBoolean("ownsSpeakeasy")) {
	return "You don't own a speakeasy";
	}
	return null;
	}

[Rinn]

honestly i don't want to deal with this i don't have time

[gausie]

I intentionally didn't name this property to contain "Available", or "Always", or "Accessable" for this very reason.

Here is an example:

kolmafia/src/net/sourceforge/kolmafia/request/FancyDanRequest.java

Lines 94 to 100 in 3877c6f

	public static String accessible() {
	if (!Preferences.getBoolean("ownsSpeakeasy")) {
	return "You don't own a speakeasy";
	}
	return null;
	}

That is a bad example. ownsSpeakeasy is one requirement to it being accessible. Others need to be added and will be in the future when the item is no longer in standard or is otherwise routinely unavailable.

[jaadams5]

coolitems in the API has nothing to say about this?

[gausie]

Sadly not

…

On Thu, 27 Jul 2023, 21:44 Jamie Adams, ***@***.***> wrote: coolitems in the API has nothing to say about this? — Reply to this email directly, view it on GitHub <#1856 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABL4LQIZYUKLP6QVV5PIU3XSLHLHANCNFSM6AAAAAA22NQPWQ> . You are receiving this because your review was requested.Message ID: ***@***.***>