Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print if in a fight for florist check #1861

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Don't print if in a fight for florist check #1861

merged 2 commits into from
Jul 30, 2023

Conversation

Rinn
Copy link
Contributor

@Rinn Rinn commented Jul 30, 2023

I caused some "You are currently in a choice." or "You are currently in a fight." spam from scripts like tourguide that call florist_available() regularly.

Also busta found an issue, we still need to hit fv_friar before doing the request or it may not succeed. I removed that thinking it was an optimization to not hit the page unnecessarily but it was necessary.

@Rinn Rinn requested a review from a team as a code owner July 30, 2023 00:16
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #1861 (596948b) into main (61f6ccc) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1861   +/-   ##
=========================================
  Coverage     36.33%   36.33%           
  Complexity    18764    18764           
=========================================
  Files          1081     1081           
  Lines        166345   166347    +2     
  Branches      35394    35394           
=========================================
+ Hits          60435    60437    +2     
  Misses        96038    96038           
  Partials       9872     9872           
Files Changed Coverage Δ
...t/sourceforge/kolmafia/request/FloristRequest.java 47.41% <0.00%> (-0.45%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f6ccc...596948b. Read the comment docs.

this was a bad optimization on my part
@Rinn Rinn merged commit a63df79 into main Jul 30, 2023
8 checks passed
@Rinn Rinn deleted the florist-spam branch July 30, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant