Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly detect fancy topmenu style from account interface tab #1865

Merged
merged 8 commits into from
Jul 31, 2023

Conversation

Veracity0
Copy link
Contributor

@Veracity0 Veracity0 commented Jul 31, 2023

The radio button for "fancy" is "Customizable Icons or Text", not "Icons"

@Veracity0 Veracity0 requested a review from a team as a code owner July 31, 2023 17:16
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1865 (de434a2) into main (dd7a332) will increase coverage by 0.02%.
The diff coverage is 80.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1865      +/-   ##
============================================
+ Coverage     36.34%   36.37%   +0.02%     
- Complexity    18769    18782      +13     
============================================
  Files          1081     1081              
  Lines        166357   166359       +2     
  Branches      35398    35397       -1     
============================================
+ Hits          60467    60509      +42     
+ Misses        96015    95966      -49     
- Partials       9875     9884       +9     
Files Changed Coverage Δ
...t/sourceforge/kolmafia/request/AccountRequest.java 30.70% <80.00%> (+15.62%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7a332...de434a2. Read the comment docs.

@Veracity0 Veracity0 merged commit cc754fa into main Jul 31, 2023
8 checks passed
@Veracity0 Veracity0 deleted the account-request-menu-style branch July 31, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants