Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Fixes #1866

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Test Fixes #1866

merged 3 commits into from
Jul 31, 2023

Conversation

jaadams5
Copy link
Contributor

In the process of trying to sort out #1811 I ran locally with one fork for gradle. In the past that has given a deterministic test order. Two tests failed. I was able to reproduce the failures with 4 forks and when I ran the tests individually in IntelliJ. These changes fix that.

For the one test the test class structure appeared to prevent the beforeEach from running before the test. That hypothesis was supported by un-initialized preference values in the test according to the debugger.

For the other test the Familiar data was just nonexistent.

This code works individually in my IDE and when running with four forks.

@jaadams5 jaadams5 requested a review from a team as a code owner July 31, 2023 17:32
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1866 (e7afa46) into main (e27e45d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1866      +/-   ##
============================================
- Coverage     36.34%   36.34%   -0.01%     
+ Complexity    18768    18767       -1     
============================================
  Files          1081     1081              
  Lines        166357   166357              
  Branches      35398    35398              
============================================
- Hits          60465    60462       -3     
- Misses        96016    96019       +3     
  Partials       9876     9876              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e27e45d...e7afa46. Read the comment docs.

@jaadams5 jaadams5 merged commit dd7a332 into main Jul 31, 2023
8 checks passed
@jaadams5 jaadams5 deleted the testfixes branch July 31, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants