feat: august skeleton items etc #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing because "toilet paper" now also matches "handful of toilet paper" (I assume). The tests were written assuming an exact match would match the specific item, but something is going wrong. |
|
"toilet paper" is not the name of the item. The name of the item is "roll of toilet paper". |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1867 +/- ##
=========================================
Coverage 36.37% 36.37%
+ Complexity 18782 18781 -1
=========================================
Files 1081 1081
Lines 166359 166359
Branches 35397 35397
=========================================
Hits 60509 60509
Misses 95966 95966
Partials 9884 9884 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jaadams5
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, just dump everything.
Needs a preference for skills cast (5 + 1 for the current day), fixodent "Craft with Teeth" store (takes fixodent + loose teeth, so probably like Sliemce?)