Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replica august + monster drop rates #1868

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

midgleyc
Copy link
Member

@midgleyc midgleyc commented Aug 1, 2023

Conditions on the Deep Machine monsters are that the hollow spleen items
need the corresponding filled spleen item effect.

Conditions on the NEP are that the drop rate decreases for each item you
get in a single day (individually). This isn't really a "condition" but
it's close enough.

Conditions on the Deep Machine monsters are that the hollow spleen items
need the corresponding filled spleen item effect.

Conditions on the NEP are that the drop rate decreases for each item you
get in a single day (individually). This isn't really a "condition" but
it's close enough.
@midgleyc midgleyc requested a review from a team as a code owner August 1, 2023 16:21
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1868 (1e1af3c) into main (0adb71b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1868      +/-   ##
============================================
- Coverage     36.37%   36.36%   -0.01%     
+ Complexity    18782    18781       -1     
============================================
  Files          1081     1081              
  Lines        166360   166361       +1     
  Branches      35398    35398              
============================================
- Hits          60510    60504       -6     
- Misses        95966    95976      +10     
+ Partials       9884     9881       -3     
Files Changed Coverage Δ
.../net/sourceforge/kolmafia/objectpool/ItemPool.java 14.28% <ø> (ø)
...eforge/kolmafia/request/ReplicaMrStoreRequest.java 81.89% <100.00%> (+0.15%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0adb71b...1e1af3c. Read the comment docs.

@midgleyc midgleyc enabled auto-merge (squash) August 1, 2023 20:53
@midgleyc midgleyc merged commit 03e2934 into kolmafia:main Aug 1, 2023
5 checks passed
@midgleyc midgleyc deleted the replica-august branch August 1, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants