Put TopMenuStyle detection under a debug flag #1869
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Captain Scotch and others noticed that their "relay scripts" dropdown occasionally disappeared from their awesomemenu.
Since we only set topmenu style in three places:
this was confusing.
I inserted debug code to deduce the topmenu style from the responseText every time we decorated it to add the relay scripts dropdown.
Turns out that "visiting interface tab in account.php" was broken: KoL had changed the tag on the radio button, so if you had the "fancy" style selected, we'd think it was "normal".
With that fixed - and there are now extensive tests in AccountRequestTest - everything seems to be peachy.
Doing text searches to deduce menu style every time we decorate it is (again) no longer necessary.
I considered just ripping out that code, but I left it in under a debug conditional, controlled by debugTopMenuStyle, just in case we want to test with it in the future.