Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: item drops #1873

Merged
merged 1 commit into from
Aug 3, 2023
Merged

feat: item drops #1873

merged 1 commit into from
Aug 3, 2023

Conversation

midgleyc
Copy link
Member

@midgleyc midgleyc commented Aug 3, 2023

Various PFC spading.

For the drunken rat king, I put the whiskers at 100% from Wildfire testing assuming that only 100% drops didn't burn, but quest items don't burn either, so this was just wrong. Tested again at -100% drop.

@midgleyc midgleyc requested a review from a team as a code owner August 3, 2023 16:46
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1873 (9f8ef5c) into main (4d96573) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1873      +/-   ##
============================================
- Coverage     36.37%   36.36%   -0.01%     
+ Complexity    18782    18780       -2     
============================================
  Files          1081     1081              
  Lines        166364   166364              
  Branches      35399    35399              
============================================
- Hits          60507    60506       -1     
  Misses        95973    95973              
- Partials       9884     9885       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d96573...9f8ef5c. Read the comment docs.

@midgleyc midgleyc merged commit 5b51315 into kolmafia:main Aug 3, 2023
5 checks passed
@midgleyc midgleyc deleted the item-drops branch August 3, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants