Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak PingOptionsPanel so that 3 triggers will fit on LoginFrame #1877

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

Veracity0
Copy link
Contributor

Primarily, moved pingStealthyTimein checkbox to a panel with TimeInButton - which is in Preferences/General/Connection Options but not in LoginFrame/Connection

@Veracity0 Veracity0 requested a review from a team as a code owner August 4, 2023 20:15
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1877 (589603c) into main (dc8b929) will decrease coverage by 0.01%.
The diff coverage is 9.09%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1877      +/-   ##
============================================
- Coverage     36.33%   36.33%   -0.01%     
  Complexity    18782    18782              
============================================
  Files          1081     1081              
  Lines        166564   166566       +2     
  Branches      35432    35432              
============================================
  Hits          60514    60514              
- Misses        96165    96167       +2     
  Partials       9885     9885              
Files Changed Coverage Δ
...net/sourceforge/kolmafia/swingui/OptionsFrame.java 0.00% <0.00%> (ø)
...ge/kolmafia/swingui/panel/ConfigQueueingPanel.java 35.13% <0.00%> (-0.98%) ⬇️
...forge/kolmafia/swingui/panel/PingOptionsPanel.java 0.00% <ø> (ø)
...mafia/swingui/widget/PreferenceFloatTextField.java 0.00% <0.00%> (ø)
...ge/kolmafia/swingui/widget/PreferenceCheckBox.java 90.47% <100.00%> (ø)
...fia/swingui/widget/PreferenceIntegerTextField.java 90.19% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc8b929...589603c. Read the comment docs.

@Veracity0 Veracity0 merged commit ec789ec into main Aug 4, 2023
8 checks passed
@Veracity0 Veracity0 deleted the ping-gui-tweaks branch August 4, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant