Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Picking for test #1890

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Cherry Picking for test #1890

merged 1 commit into from
Aug 8, 2023

Conversation

jaadams5
Copy link
Contributor

@jaadams5 jaadams5 commented Aug 8, 2023

verboseDelete proved very helpful to me when checking for test leakage exposed when the number of forks gradle used was changed. The leakage from MallPriceDatabaseTest was discovered and fixed as part of #1811

This copies that code from the now reverted PR. This seemed like the easiest way to preserve it and not forget it.

@jaadams5 jaadams5 requested a review from a team as a code owner August 8, 2023 12:10
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1890 (5144397) into main (dfcf477) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1890   +/-   ##
=========================================
  Coverage     36.31%   36.31%           
- Complexity    18799    18800    +1     
=========================================
  Files          1082     1082           
  Lines        166441   166441           
  Branches      35389    35389           
=========================================
+ Hits          60441    60451   +10     
+ Misses        96137    96122   -15     
- Partials       9863     9868    +5     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfcf477...5144397. Read the comment docs.

@jaadams5 jaadams5 merged commit 9f81c8c into main Aug 8, 2023
8 checks passed
@jaadams5 jaadams5 deleted the cherries branch August 8, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants