Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gingerbread item drop spading #1894

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Conversation

midgleyc
Copy link
Member

Items marked c0 failed to drop with +4900%, so there's something going on there, and I doubt it'll get spaded without a large number of logs.

Other than that, drop rates for gingerbread city (minus the Vigilante, who's very hard to encounter). Pickpocket rate for Equivocator (approx, from wiki). cheerless mime executive hasn't dropped the warehouse key since that Crimbo ended.

@midgleyc midgleyc requested a review from a team as a code owner August 11, 2023 15:59
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1894 (c0e6154) into main (77430a5) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1894   +/-   ##
=========================================
  Coverage     36.36%   36.37%           
- Complexity    18821    18824    +3     
=========================================
  Files          1083     1083           
  Lines        166540   166540           
  Branches      35397    35397           
=========================================
+ Hits          60567    60576    +9     
+ Misses        96100    96090   -10     
- Partials       9873     9874    +1     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77430a5...c0e6154. Read the comment docs.

@midgleyc midgleyc merged commit d1ec422 into kolmafia:main Aug 11, 2023
5 checks passed
@midgleyc midgleyc deleted the gingerbread-items branch August 11, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants