Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Of all comparison operators, composite values only allow equality operators #1896

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

Veracity0
Copy link
Contributor

With composites, allow "==", "!=", and "≈".
Other comparisons - "<", "<=", ">", ">=" - are meaningless and generate a compile-time error.

This simplifies things a lot: CompositeType no longer needs a compareTo method.

@Veracity0 Veracity0 requested a review from a team as a code owner August 14, 2023 13:50
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #1896 (6f7defb) into main (f8e1b0d) will decrease coverage by 0.01%.
The diff coverage is 77.14%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1896      +/-   ##
============================================
- Coverage     36.37%   36.37%   -0.01%     
+ Complexity    18845    18826      -19     
============================================
  Files          1083     1083              
  Lines        166591   166580      -11     
  Branches      35412    35384      -28     
============================================
- Hits          60605    60592      -13     
- Misses        96106    96111       +5     
+ Partials       9880     9877       -3     
Files Changed Coverage Δ
...orge/kolmafia/textui/parsetree/CompositeValue.java 13.72% <ø> (-6.97%) ⬇️
...t/sourceforge/kolmafia/textui/parsetree/Value.java 60.74% <50.00%> (-0.35%) ⬇️
...ourceforge/kolmafia/textui/parsetree/Operator.java 49.29% <82.75%> (-0.98%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e1b0d...6f7defb. Read the comment docs.

@Veracity0 Veracity0 merged commit 9d8929c into main Aug 14, 2023
8 checks passed
@Veracity0 Veracity0 deleted the composite-comparison branch August 14, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants