Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new short items #1900

Merged
merged 3 commits into from
Aug 15, 2023
Merged

feat: new short items #1900

merged 3 commits into from
Aug 15, 2023

Conversation

midgleyc
Copy link
Member

Drops from monsters in the path. Visible in the mall.

@midgleyc midgleyc requested a review from a team as a code owner August 15, 2023 16:57
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1900 (b5900a6) into main (4de3c35) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1900      +/-   ##
============================================
- Coverage     36.37%   36.37%   -0.01%     
+ Complexity    18829    18828       -1     
============================================
  Files          1083     1083              
  Lines        166587   166587              
  Branches      35388    35388              
============================================
- Hits          60604    60602       -2     
- Misses        96106    96107       +1     
- Partials       9877     9878       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de3c35...b5900a6. Read the comment docs.

jaadams5
jaadams5 previously approved these changes Aug 15, 2023
@midgleyc
Copy link
Member Author

using the merge button didn't use to dismiss reviews :(

@midgleyc midgleyc merged commit 118615f into kolmafia:main Aug 15, 2023
5 checks passed
@jaadams5
Copy link
Contributor

I don't remember that being the case either.

@midgleyc midgleyc deleted the short-items branch August 15, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants