Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log serendipity message before additional drop #1901

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

midgleyc
Copy link
Member

Make it easier to tell when a drop came from serendipity.

@midgleyc midgleyc requested a review from a team as a code owner August 15, 2023 18:49
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1901 (ea3f6b2) into main (5710869) will increase coverage by 0.00%.
The diff coverage is 28.57%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1901   +/-   ##
=========================================
  Coverage     36.37%   36.37%           
- Complexity    18826    18827    +1     
=========================================
  Files          1083     1083           
  Lines        166580   166587    +7     
  Branches      35384    35388    +4     
=========================================
+ Hits          60593    60603   +10     
+ Misses        96110    96106    -4     
- Partials       9877     9878    +1     
Files Changed Coverage Δ
...et/sourceforge/kolmafia/objectpool/EffectPool.java 100.00% <ø> (ø)
...net/sourceforge/kolmafia/request/FightRequest.java 34.29% <28.57%> (-0.01%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5710869...ea3f6b2. Read the comment docs.

@midgleyc midgleyc merged commit 4de3c35 into kolmafia:main Aug 15, 2023
5 checks passed
@midgleyc midgleyc deleted the log-serendipity branch August 15, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants