Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track august scepter sniff / banish #1902

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Conversation

midgleyc
Copy link
Member

We don't know the specifics of Hold Hands, but track it anyway.

Track Roar like a Lion (banish, lasts until rollover).

Follow-up to #1899 by fixing the ascension reset.

@midgleyc midgleyc requested a review from a team as a code owner August 16, 2023 18:18
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1902 (c7567d8) into main (0cb3a21) will increase coverage by 0.00%.
The diff coverage is 12.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1902   +/-   ##
=========================================
  Coverage     36.37%   36.37%           
- Complexity    18829    18830    +1     
=========================================
  Files          1083     1083           
  Lines        166594   166601    +7     
  Branches      35389    35391    +2     
=========================================
+ Hits          60605    60609    +4     
- Misses        96111    96112    +1     
- Partials       9878     9880    +2     
Files Changed Coverage Δ
.../sourceforge/kolmafia/preferences/Preferences.java 83.54% <ø> (ø)
...net/sourceforge/kolmafia/request/FightRequest.java 34.26% <0.00%> (-0.04%) ⬇️
...et/sourceforge/kolmafia/session/BanishManager.java 96.71% <100.00%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cb3a21...c7567d8. Read the comment docs.

@midgleyc midgleyc merged commit 7b2d67b into kolmafia:main Aug 17, 2023
5 checks passed
@midgleyc midgleyc deleted the banish-roar branch August 17, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants