Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more small stuff #1903

Merged
merged 1 commit into from
Aug 17, 2023
Merged

feat: more small stuff #1903

merged 1 commit into from
Aug 17, 2023

Conversation

midgleyc
Copy link
Member

Locations / monsters / path, path ignores stat requirements.

Haven't spaded all the monsters yet but did check ncle, daddy shortlegs and rutabaga bug, and they all matched 50 equipment / 30 potion so I think it's reasonably likely.

@midgleyc midgleyc requested a review from a team as a code owner August 17, 2023 16:36
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #1903 (18c5048) into main (7b2d67b) will increase coverage by 0.00%.
The diff coverage is 25.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1903   +/-   ##
=========================================
  Coverage     36.37%   36.37%           
- Complexity    18824    18827    +3     
=========================================
  Files          1083     1083           
  Lines        166601   166605    +4     
  Branches      35391    35391           
=========================================
+ Hits          60598    60602    +4     
+ Misses        96124    96122    -2     
- Partials       9879     9881    +2     
Files Changed Coverage Δ
src/net/sourceforge/kolmafia/KoLCharacter.java 64.28% <0.00%> (-0.03%) ⬇️
...sourceforge/kolmafia/session/EquipmentManager.java 43.20% <0.00%> (-0.08%) ⬇️
src/net/sourceforge/kolmafia/AscensionPath.java 89.47% <100.00%> (+0.11%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2d67b...18c5048. Read the comment docs.

@midgleyc midgleyc merged commit ce9136e into kolmafia:main Aug 17, 2023
5 checks passed
@midgleyc midgleyc deleted the more-small branch August 17, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants