feat: improvements to running small #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1909 +/- ##
============================================
- Coverage 36.37% 36.37% -0.01%
- Complexity 18831 18833 +2
============================================
Files 1083 1083
Lines 166619 166628 +9
Branches 35393 35397 +4
============================================
+ Hits 60613 60615 +2
- Misses 96122 96125 +3
- Partials 9884 9888 +4
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
midgleyc
force-pushed
the
running-small
branch
from
09ee8f0
to
0d1a697
Compare
jaadams5
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way stats work in Small is that your black stats are capped at 1, but your level is uncapped.
Implement this by ignoring charsheet requests, trusting api.php for the stats, and adding a modifier that limits your stats to 1. This makes maximizer + numberology work as desired (i.e. maximizer treats percentage buffs as acting on 1, numberology gets your level correct).
Limit fullness and inebriety.
Skip parsing campground for now. I have HTMLs, I will get back to it later. Your housing never shows up -- it's just "rest in the dirt", but we could parse whether you have free rests left.
Don't count Long Winter's Nap if it's out of standard, which it is now.