Property _beachTides is tide-washed row count #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaadams5
previously approved these changes
Aug 21, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1912 +/- ##
============================================
+ Coverage 36.37% 36.45% +0.07%
- Complexity 18832 18865 +33
============================================
Files 1083 1083
Lines 166628 166629 +1
Branches 35397 35397
============================================
+ Hits 60613 60744 +131
+ Misses 96126 95981 -145
- Partials 9889 9904 +15
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Previously approved with failing test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you comb a tile on the beach, we supposedly change that code in _beachLayout to a 'c'.
Except, it was checking for "You acquire", but bottles and whales do not "acquire" anything.
Look instead for "You comb"
When we examine a beach map, the tides wash the rows at the bottom and you cannot comb them.
Property "_beachTides" now has how many such rows are unavailable. ("_beachLayout" will have rows from N+1 - 10).