Add basic support for the Flea Market #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1923 +/- ##
============================================
+ Coverage 36.47% 36.48% +0.01%
- Complexity 18879 18895 +16
============================================
Files 1084 1086 +2
Lines 166719 166797 +78
Branches 35410 35424 +14
============================================
+ Hits 60805 60855 +50
- Misses 96000 96014 +14
- Partials 9914 9928 +14
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue was opened here: https://kolmafia.us/threads/items-placed-in-flea-market-are-not-tracked-as-removed-from-inventory.29181/
This PR just aims to correctly track when an item is added to the Flea Market and remove it from our inventory, as well as log when we buy or sell.
As a note, I'm against the idea of adding more support to the Flea Market such as a buy or sell command. Or a "whats for sale" search.
The flea market already sucks, and I don't want to see it turn into a "lets undercut each other" v2 mall. It sucks enough already without having people buy out underpriced items automatically, and undercutting each other on overpriced items automatically.
If you want to do that stuff, make your own script. It's a noob market with prices detached from reality, and we should respect that by leaving it to the noobs.
I saw someone automatically undercut everyone on the flea market so that they were the only seller, if you placed new items for sale they automatically added an item that undercut you.. It was worse than in mall, at least in the mall I can ignore your store to buy the next cheapest. They did eventually stop, but still.