Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add modifiers for resolutions / circadian rhythms #1933

Merged
merged 3 commits into from
Sep 2, 2023

Conversation

midgleyc
Copy link
Member

@midgleyc midgleyc commented Sep 2, 2023

Track rollover adventures gained by these skills in modtrace.

Also add a test for logging cartography, because it took me a while to track down where that was happening.

@midgleyc midgleyc requested a review from a team as a code owner September 2, 2023 09:58
@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #1933 (291a55b) into main (d9bf1ce) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1933      +/-   ##
============================================
- Coverage     36.51%   36.50%   -0.01%     
  Complexity    18921    18921              
============================================
  Files          1086     1086              
  Lines        166834   166840       +6     
  Branches      35438    35440       +2     
============================================
- Hits          60918    60913       -5     
- Misses        95988    96000      +12     
+ Partials       9928     9927       -1     
Files Changed Coverage Δ
...net/sourceforge/kolmafia/request/FightRequest.java 34.42% <ø> (ø)
src/net/sourceforge/kolmafia/KoLCharacter.java 64.32% <33.33%> (+<0.01%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9bf1ce...291a55b. Read the comment docs.

@midgleyc midgleyc enabled auto-merge (squash) September 2, 2023 18:04
@midgleyc midgleyc merged commit 80ae34c into kolmafia:main Sep 2, 2023
5 checks passed
@midgleyc midgleyc deleted the resolution-modifier branch September 2, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants