Call recalculateAdjustments after loading skills. #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also includes a couple more changes to make sure that we don't accidentally populate availablePassiveSkillModifiersByVariable before we have any skills ready. This doesn't handle the scenario where the skills list changes, but it should handle the most common scenarios (login, kingLiberated come to mind).
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2011 +/- ##
============================================
+ Coverage 36.97% 36.99% +0.01%
- Complexity 19278 19298 +20
============================================
Files 1090 1090
Lines 167224 167227 +3
Branches 35430 35431 +1
============================================
+ Hits 61829 61862 +33
+ Misses 95475 95462 -13
+ Partials 9920 9903 -17
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
nasurte
pushed a commit
to nasurte/kolmafia
that referenced
this pull request
Oct 30, 2023
This also includes a couple more changes to make sure that we don't accidentally populate availablePassiveSkillModifiersByVariable before we have any skills ready. This doesn't handle the scenario where the skills list changes, but it should handle the most common scenarios (login, kingLiberated come to mind).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes a couple more changes to make sure that we don't accidentally populate availablePassiveSkillModifiersByVariable before we have any skills ready.
This doesn't handle the scenario where the skills list changes, but it should handle the most common scenarios (login, kingLiberated come to mind).