Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark items as multiusable, thanks to adeyke #2019

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

midgleyc
Copy link
Member

Mark the items given in https://kolmafia.us/threads/missing-multiusable-items.29317/ as multiusable.

@midgleyc midgleyc requested a review from a team as a code owner October 21, 2023 13:34
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #2019 (e63f4a7) into main (c0a5572) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2019   +/-   ##
=========================================
  Coverage     37.01%   37.01%           
  Complexity    19311    19311           
=========================================
  Files          1090     1090           
  Lines        167240   167240           
  Branches      35429    35429           
=========================================
  Hits          61904    61904           
  Misses        95426    95426           
  Partials       9910     9910           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a5572...e63f4a7. Read the comment docs.

@midgleyc midgleyc merged commit d9d4431 into kolmafia:main Oct 21, 2023
5 checks passed
@midgleyc midgleyc deleted the adeyke-multiple branch October 21, 2023 13:50
@jaadams5
Copy link
Contributor

Thank you.

Might it be worth adding a new command to KoLmafia that would iterate through the items and validate key attributes against KoL? I don't think we want a test because this would have to have live access to KoL.

@midgleyc
Copy link
Member Author

We have checkdata. I think for this one we also need access to the items themselves, like checkpowers has.

nasurte pushed a commit to nasurte/kolmafia that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants