-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comment style in data files #2023
Conversation
Some lines in the combats.txt data files used the //-style comment - this is the only place where it is done like that. Replaced them with #-style comments.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2023 +/- ##
============================================
- Coverage 37.01% 37.00% -0.01%
+ Complexity 19311 19309 -2
============================================
Files 1090 1090
Lines 167240 167240
Branches 35429 35429
============================================
- Hits 61908 61895 -13
- Misses 95419 95434 +15
+ Partials 9913 9911 -2 see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is useful for non-mafia parsers that use these data files. Not approving in case someone else knows a reason these should be kept? It seems weird so perhaps is on purpose.
The comments in question were added by @Veracity0 08/27/2019. In my case I have been coding and scripting long enough that "#" is not my first expectation for a comment character and I might not have noticed that I had mixed and matched commenting styles. Perhaps something similar is the case here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked and this is only being skipped because it doesn't contain a tab. Approving this
Some lines in the combats.txt data files used the //-style comment - this is the only place where it is done like that. Replaced them with #-style comments.
Some lines in the combats.txt data files used the //-style comment - this is the only place where it is done like that. Replaced them with #-style comments.