Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment style in data files #2023

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

Semenar
Copy link
Contributor

@Semenar Semenar commented Oct 23, 2023

Some lines in the combats.txt data files used the //-style comment - this is the only place where it is done like that. Replaced them with #-style comments.

Some lines in the combats.txt data files used the //-style comment - this is the only place where it is done like that. Replaced them with #-style comments.
@Semenar Semenar requested a review from a team as a code owner October 23, 2023 21:50
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2023 (45fd994) into main (4b6a983) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2023      +/-   ##
============================================
- Coverage     37.01%   37.00%   -0.01%     
+ Complexity    19311    19309       -2     
============================================
  Files          1090     1090              
  Lines        167240   167240              
  Branches      35429    35429              
============================================
- Hits          61908    61895      -13     
- Misses        95419    95434      +15     
+ Partials       9913     9911       -2     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6a983...45fd994. Read the comment docs.

Copy link
Contributor

@gausie gausie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is useful for non-mafia parsers that use these data files. Not approving in case someone else knows a reason these should be kept? It seems weird so perhaps is on purpose.

@jaadams5
Copy link
Contributor

The comments in question were added by @Veracity0 08/27/2019.

In my case I have been coding and scripting long enough that "#" is not my first expectation for a comment character and I might not have noticed that I had mixed and matched commenting styles. Perhaps something similar is the case here?

Copy link
Contributor

@gausie gausie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and this is only being skipped because it doesn't contain a tab. Approving this

@gausie gausie enabled auto-merge (squash) October 24, 2023 13:43
@gausie gausie merged commit 5f73953 into kolmafia:main Oct 24, 2023
5 checks passed
@Semenar Semenar deleted the unified-comment-style branch October 24, 2023 14:10
nasurte pushed a commit to nasurte/kolmafia that referenced this pull request Oct 30, 2023
Some lines in the combats.txt data files used the //-style comment - this is the only place where it is done like that. Replaced them with #-style comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants