AutoFilterComboBox-raw-type #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so it can become String. Thanks god, otherwise this threw a wrench in everything...
as a replacement of the editable version of AutoFilterComboBox
heeheehee-kolmafia
requested changes
Nov 9, 2021
| } | ||
|
|
||
| public String getText() { | ||
| return (String) (this.getSelectedItem() != null ? this.getSelectedItem() : this.currentMatch); |
There was a problem hiding this comment.
(I hate that LcokableListModel.getSelectedItem returns an Object instead of a genericized type...)
There was a problem hiding this comment.
(why are we even still using that? Wasn't it used for the lockable aspect, which got removed?)
There was a problem hiding this comment.
At this point, LockableListModel is a (Swing) ListModel that has a notion of visible / hidden elements based on a custom filter.
src/net/sourceforge/kolmafia/swingui/widget/EditableAutoFilterComboBox.java
Outdated
Show resolved
Hide resolved
heeheehee-kolmafia
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoFilterComboBox was split into two "modes": editable, and not.
This PR isolates the editable mode into its own class, "EditableAutoFilterComboBox", whose generic is locked as String.
This allows AutoFilterComboBox to have its own Generic.