Persistent Command Buffer #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2047 +/- ##
============================================
- Coverage 37.08% 37.08% -0.01%
Complexity 19376 19376
============================================
Files 1093 1093
Lines 167505 167518 +13
Branches 35464 35465 +1
============================================
Hits 62117 62117
- Misses 95460 95473 +13
Partials 9928 9928
Continue to review full report in Codecov by Sentry.
|
midgleyc
reviewed
Nov 5, 2023
src/net/sourceforge/kolmafia/swingui/panel/CommandDisplayPanel.java
Outdated
Show resolved
Hide resolved
midgleyc
reviewed
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://kolmafia.us/threads/persistent-command-history-control-history-size.29213/
This saves the gCLI and tabbed chat command buffers to separate GLOBAL preferences. The commands are in a list delimited by the sharp sign which some people insist on calling a hashtag. The list is loaded on start up and the command index is set to the last element so an up arrow in a new session should select the last command from the previous session.
I've lightly tested this with the gCLI but not tabbed chat.
There was a request to allow the size of the buffer to be a preference. I decided NOT to implement that because if the size changed then the CommandDisplayFrame would have to be rebuilt or mafia shutdown and restarted before the effect was noticeable. It is trivial, now or later, to change the hardcoded 20 to something else if that is what people want.