Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make daily deeds advs readable, add potted plant advs text #2130

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

libraryaddict
Copy link
Contributor

Sometimes you can tell when someone just didn't feel like thinking about it.
I don't blame them, but it was too much for my poor brain to handle so I simplified the code.

  • Added potted plant to the daily deeds display
  • Added Some tests
  • Minor rework of the code for what text is displayed so that it is easier to read, and add onto in the future.

@libraryaddict libraryaddict requested a review from a team as a code owner December 25, 2023 06:45
midgleyc
midgleyc previously approved these changes Dec 25, 2023
Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to fix the spotless thing, but looks good other than that.

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (dff8289) 37.02% compared to head (7aca29b) 37.03%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2130      +/-   ##
============================================
+ Coverage     37.02%   37.03%   +0.01%     
+ Complexity    19436    19435       -1     
============================================
  Files          1101     1101              
  Lines        168245   168241       -4     
  Branches      35610    35600      -10     
============================================
+ Hits          62290    62315      +25     
+ Misses        95980    95937      -43     
- Partials       9975     9989      +14     
Files Coverage Δ
...eforge/kolmafia/swingui/panel/DailyDeedsPanel.java 8.54% <32.25%> (+1.04%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff8289...7aca29b. Read the comment docs.

@midgleyc midgleyc merged commit 494b6cf into kolmafia:main Dec 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants