Add missing Gnome adventure activation strings #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2136 +/- ##
=========================================
Coverage 37.11% 37.11%
- Complexity 19493 19498 +5
=========================================
Files 1102 1102
Lines 168448 168448
Branches 35600 35600
=========================================
+ Hits 62519 62523 +4
+ Misses 95945 95939 -6
- Partials 9984 9986 +2
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
midgleyc
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simply an addition (along with alphabetizing) of the missing Reagnimated Gnome adventure gain strings to catch when the Gnome's ability activates. This will allow the existing built in preference and Daily Deeds panel tracking to record a more accurate value for adventures gained.