Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use commas in encounter listing #2140

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

midgleyc
Copy link
Member

For consistency with adventure results.

@midgleyc midgleyc requested a review from a team as a code owner December 30, 2023 14:04
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5f29e7) 37.12% compared to head (a93c329) 37.12%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2140      +/-   ##
============================================
- Coverage     37.12%   37.12%   -0.01%     
+ Complexity    19500    19499       -1     
============================================
  Files          1102     1102              
  Lines        168450   168450              
  Branches      35603    35603              
============================================
- Hits          62540    62533       -7     
- Misses        95923    95933      +10     
+ Partials       9987     9984       -3     
Files Coverage Δ
...sourceforge/kolmafia/session/EncounterManager.java 83.33% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5f29e7...a93c329. Read the comment docs.

@midgleyc midgleyc merged commit 8f1c603 into kolmafia:main Dec 30, 2023
5 checks passed
@midgleyc midgleyc deleted the encounter-listing-commas branch December 30, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants