Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: crimbuccaneer grub hall #2141

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Conversation

midgleyc
Copy link
Member

No description provided.

@midgleyc midgleyc requested a review from a team as a code owner December 30, 2023 18:41
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (8f1c603) 37.12% compared to head (d06777a) 37.12%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2141      +/-   ##
============================================
- Coverage     37.12%   37.12%   -0.01%     
- Complexity    19499    19506       +7     
============================================
  Files          1102     1103       +1     
  Lines        168450   168500      +50     
  Branches      35603    35609       +6     
============================================
+ Hits          62533    62549      +16     
- Misses        95933    95964      +31     
- Partials       9984     9987       +3     
Files Coverage Δ
...c/net/sourceforge/kolmafia/CoinmasterRegistry.java 87.17% <ø> (+2.56%) ⬆️
src/net/sourceforge/kolmafia/RequestLogger.java 30.77% <0.00%> (-0.12%) ⬇️
...urceforge/kolmafia/request/NPCPurchaseRequest.java 20.18% <0.00%> (-0.11%) ⬇️
...sourceforge/kolmafia/swingui/CoinmastersFrame.java 0.00% <0.00%> (ø)
...ge/kolmafia/request/Crimbo23PirateCafeRequest.java 41.17% <41.17%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f1c603...d06777a. Read the comment docs.

Copy link
Contributor

@Veracity0 Veracity0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@midgleyc midgleyc merged commit c8b4825 into kolmafia:main Dec 31, 2023
5 checks passed
@midgleyc midgleyc deleted the pirate-grub-hall branch December 31, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants