Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spring shoes skills #2200

Merged
merged 2 commits into from Feb 12, 2024
Merged

add spring shoes skills #2200

merged 2 commits into from Feb 12, 2024

Conversation

ckb11
Copy link
Contributor

@ckb11 ckb11 commented Feb 11, 2024

No description provided.

@ckb11 ckb11 requested a review from a team as a code owner February 11, 2024 21:41
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58b0984) 37.07% compared to head (ceb2d31) 37.07%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2200   +/-   ##
=========================================
  Coverage     37.07%   37.07%           
- Complexity    19522    19525    +3     
=========================================
  Files          1106     1106           
  Lines        168866   168866           
  Branches      35682    35682           
=========================================
+ Hits          62603    62606    +3     
+ Misses        96295    96291    -4     
- Partials       9968     9969    +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58b0984...ceb2d31. Read the comment docs.

Copy link
Contributor

@Veracity0 Veracity0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "test/root/request/test_adventures_spent_airship_12 (1).json"?
It's empty and doesn't seem relevant to this commit, even if it weren't.

@ckb11
Copy link
Contributor Author

ckb11 commented Feb 12, 2024

I don't know what that josn file is. Thats probably an artifact of me just learning how to use git. How do I fix that?
Edit: looks like I can delete that from this PR, so thats done.

@Veracity0 Veracity0 merged commit 8fdd2cc into kolmafia:main Feb 12, 2024
5 checks passed
@ckb11 ckb11 deleted the springskills branch February 12, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants