Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Campground in WereProfessor. Improved Fulminate warning #2233

Merged
merged 2 commits into from Mar 11, 2024

Conversation

Veracity0
Copy link
Contributor

  1. No Campground if WereProfessor.
    You can still buy and use a Dramatic range, and it is needed to make unstable fulminate.
    We can't see it in the campground, but, fortunately, the "hasRange" property exists.
  2. Don't warn that you don't have unstable fulminate equipped if you don't have it or can't make it.
  3. If you have it but not equipped, offer to equip it.
  4. If you don't have it but can make it, offer to make it.

@Veracity0 Veracity0 requested a review from a team as a code owner March 11, 2024 17:29
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 37.38%. Comparing base (8c743a5) to head (32c368e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2233      +/-   ##
============================================
+ Coverage     37.35%   37.38%   +0.02%     
- Complexity    19766    19787      +21     
============================================
  Files          1109     1109              
  Lines        169451   169476      +25     
  Branches      35795    35801       +6     
============================================
+ Hits          63300    63352      +52     
+ Misses        96121    96091      -30     
- Partials      10030    10033       +3     
Files Coverage Δ
...et/sourceforge/kolmafia/objectpool/Concoction.java 68.43% <100.00%> (+0.21%) ⬆️
.../net/sourceforge/kolmafia/objectpool/ItemPool.java 14.28% <ø> (ø)
...net/sourceforge/kolmafia/request/RelayRequest.java 36.58% <100.00%> (+1.50%) ⬆️
src/net/sourceforge/kolmafia/KoLmafia.java 38.22% <0.00%> (-0.05%) ⬇️
...sourceforge/kolmafia/session/LightsOutManager.java 5.40% <0.00%> (+2.62%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c743a5...32c368e. Read the comment docs.

@Veracity0 Veracity0 merged commit 1b21d0c into main Mar 11, 2024
8 checks passed
@Veracity0 Veracity0 deleted the improved-fulminate-warning branch March 11, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants