Changing form requires concoction refresh. Drop transformed outfit pieces from checkpoints. #2236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that CreateItemRequest creates an outfit checkpoint around creations and it wants to re-equip the original exo- skeleton after creating it. In fact, it tries to re-make it - which fails, since it is no longer a valid creation.
Now we remove the ingredients from checkpoints - for TinkeringBenchRequest equipment - after we tinker.
I suppose I could write some tests. I did turn on DEBUG logging when I did change 1 - with exoskeletons, and again, after I made the fix, with quick-release items.