Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing form requires concoction refresh. Drop transformed outfit pieces from checkpoints. #2236

Merged
merged 1 commit into from Mar 14, 2024

Conversation

Veracity0
Copy link
Contributor

  1. If you are wearing a high-tension exoskeleton and ask the Item Manager to create (and equip) a irresponsible-tension exoskeleton - and have the required 2 smashed scientific equipment - KoLmafia is happy to unequip the item and upgrade it.
    The issue is that CreateItemRequest creates an outfit checkpoint around creations and it wants to re-equip the original exo- skeleton after creating it. In fact, it tries to re-make it - which fails, since it is no longer a valid creation.

Now we remove the ingredients from checkpoints - for TinkeringBenchRequest equipment - after we tinker.

  1. You can only tinker as a Mild-Mannered Professor. When you transform to a Savage Beast - or vice versa - refresh concoctions so that Tinkering Bench items disappear and reappear as appropriate.

I suppose I could write some tests. I did turn on DEBUG logging when I did change 1 - with exoskeletons, and again, after I made the fix, with quick-release items.

@Veracity0 Veracity0 requested a review from a team as a code owner March 14, 2024 20:41
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 37.37%. Comparing base (3f5eacc) to head (6b7f6c8).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2236      +/-   ##
============================================
- Coverage     37.38%   37.37%   -0.01%     
- Complexity    19788    19789       +1     
============================================
  Files          1109     1109              
  Lines        169491   169495       +4     
  Branches      35804    35805       +1     
============================================
- Hits          63357    63354       -3     
- Misses        96094    96101       +7     
  Partials      10040    10040              
Files Coverage Δ
...eforge/kolmafia/request/TinkeringBenchRequest.java 87.30% <100.00%> (+0.41%) ⬆️
...et/sourceforge/kolmafia/session/ChoiceControl.java 10.89% <0.00%> (-0.01%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f5eacc...6b7f6c8. Read the comment docs.

@Veracity0 Veracity0 merged commit ba8f3e1 into main Mar 14, 2024
8 checks passed
@Veracity0 Veracity0 deleted the improve-tinkering branch March 14, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants